DataViews: Replace hiddenFields config with fields property instead #63127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
requested review from
oandregal,
ellatrix,
jorgefilipecosta and
ntsekouras
|
The typescript types were very helpful in this refactoring :) |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +23 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jul 4, 2024
| @@ -78,9 +78,7 @@ const DEFAULT_VIEW = { | |||
| field: 'title', | |||
| direction: 'asc', | |||
| }, | |||
| // All fields are visible by default, so it's | |||
| // better to keep track of the hidden ones. | |||
| hiddenFields: [ 'preview' ], | |||
There was a problem hiding this comment.
Question: what if you hide the preview field, but it's required in another layout?
There was a problem hiding this comment.
It's still shown in the other layout (there's special treatment for media and primary fields). That said, we've been discussing with @jameskoster and @oandregal and we'll be following-up with a PR where the visible fields and fields rendering config resets when you switch layout. We found that it makes little sense to keep these when you switch layouts (as opposed to filters...)
There was a problem hiding this comment.
Related #57596 (comment)
ellatrix
approved these changes
Jul 4, 2024
This was referenced Jul 4, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ordPress#63127) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
First step in #58012
What?
This PR replaces the
hiddenFieldsproperty in the DataViews component with afieldsproperty. And there are several reasons for this:fields(as opposed tovisibleFieldsorhiddenFields) can allow us to do a lot more than show/hide fields. It opens the door to:fields: [ { field: 'date', renderAs: 'badge' } ]Note
view.fieldsproperty.Testing Instructions
Check that the different dataviews (patterns, pages...) work as expected in different layouts (grid, table, list), that you can hide/show fields in the view dropdown or in the table headers.