Format Library: Clean up 'Highlight' format components #62965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
commented
Jun 28, 2024
Comment on lines
+140
to
+144
| onChange={ ( color ) => { | ||
| onChange( | ||
| setColors( value, name, colors, { [ property ]: color } ) | ||
| ); | ||
| } } |
There was a problem hiding this comment.
I checked other usages of the ColorPalette component; memoization isn't required.
There was a problem hiding this comment.
For clarity and my own edification, would you please elaborate on what you mean by "required?"
My interpretation is that you mean that memoizing this callback is unnecessary as ColorPalette itself it not memoized. Is that accurate?
Thanks! 🙇🏻
There was a problem hiding this comment.
My interpretation is that you mean that memoizing this callback is unnecessary as ColorPalette itself it not memoized. Is that accurate?
Correct and the onChange prop isn't a dependency for any side-effect ( useEffect ).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -31 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Jun 28, 2024
| const colorIndicatorStyle = useMemo( | ||
| () => | ||
| fillComputedColors( | ||
| contentRef.current, | ||
| getActiveColors( value, name, colors ) | ||
| ), | ||
| [ value, colors ] | ||
| [ contentRef, value, colors ] |
There was a problem hiding this comment.
Note: The contentRef is a ref object, but the ESLint plugin can't know this because it's passed as props. tl;dr; It's a false positive that we must fix, but it won't regress memo behavior.
dcalhoun
reviewed
Jun 28, 2024
Comment on lines
+140
to
+144
| onChange={ ( color ) => { | ||
| onChange( | ||
| setColors( value, name, colors, { [ property ]: color } ) | ||
| ); | ||
| } } |
There was a problem hiding this comment.
For clarity and my own edification, would you please elaborate on what you mean by "required?"
My interpretation is that you mean that memoizing this callback is unnecessary as ColorPalette itself it not memoized. Is that accurate?
Thanks! 🙇🏻
There was a problem hiding this comment.
I quickly tested the these changes on an iPhone simulator and Android emulator. I did not note any issues. Mentioning @geriux for awareness, just in case you have any concerns regarding these changes. 🙇🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR makes the following updates to the "Highlight" format components:
eslint-plugin-react-compiler#61788.Why?
It's just a routine maintenance.
Testing Instructions
The feature also has test coverage.
Testing Instructions for Keyboard
Same.
Screenshots or screencast