Manual cherry pick of #62768 to wp/6.6 #62905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S is generated (#62768) * Render styles after the variation style overrides have been saved to stage. Getting closer. But the overrides in state need to be merged with incoming revision styles. * For every current override, update the variation CSS with the incoming config from the revision. * Rename hook Destructure in hook so the consumer doesn't have to clone Only send the override overrides to EditorStyles that need to be overridden. * Fetching overrides in the hook * Feedback suggestions from review: add overrides to dep array in Editor Styles rename hook * Return getBlockStyles from the useSelect callback * Refactor so we don't have to change the EditorStyles props Register revision overrides with useStyleOverride * Adding some explanatory comments Add rudimentary E2E test covering block style partials, applying them, updating them and viewing styles revisions. * Removed unused style fixture Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: ellatrix <[email protected]>
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1 task
|
Size Change: +415 B (+0.02%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 27, 2024
ellatrix
reviewed
Jun 27, 2024
ellatrix
reviewed
Jun 28, 2024
| @@ -25,6 +25,7 @@ const { | |||
| ExperimentalBlockEditorProvider, | |||
| GlobalStylesContext, | |||
| useGlobalStylesOutputWithConfig, | |||
| __unstableBlockStyleVariationOverridesWithConfig, | |||
There was a problem hiding this comment.
Why is this __unstable? It's already private, right?
There was a problem hiding this comment.
There was a bit of discussion around it.
To answer the "why", to advertise without ambiguity that, despite being private, it's unstable.
Similar to how private block editor functions have the Experimental or Private prefixes 🤷🏻
I don't think it does any harm, but could easily be communicated in comments. I can rename it next week if you feel strongly about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A manual cherry pick of the following PRs to
wp/6.6Why?
There was a tiny conflict because the hook name change in #62464 was not cherry-picked into
wp/6.6Testing Instructions
Smoke test according to test instructions in #62768