Docs/iAPI: Fix wrong code snippet in data-wp-run example #62835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix a wrong code snippet in the
data-wp-run
example.Discovered by @fabiankaegy and reported in Slack: https://wordpress.slack.com/archives/C071CRKGKUP/p1719289120450429
Why?
The
data-wp-run
callbacks run in the body of the Preact component, andref
is basically auseRef
hook, which means thatref
isnull
on the first render.All this means that, in contrary to how it works in
data-wp-watch
anddata-wp-init
, which are basically fancy versions ofuseEffect
, you need to accessref
inside auseEffect
-like hook (useEffect
,useInit
,useWatch
…) when you usedata-wp-run
, exactly like you would use it in (P)React:How?
In this specific example, I moved the
getElement()
call to theuseEffect
hook of theuseInView
hook, soref
is notnull
anymore.