Image Block: fix Aspect Ratio button position #62776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
requested review from
ellatrix,
artemiomorales and
michalczaplinski
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
Jun 24, 2024
|
Size Change: -243 B (-0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
WP 6.6 RC1 is tomorrow and it seems there are still other tests failing 😅 This issue isn't the first time it's happened with WP6.6 so it might be best not to backport it. |
|
The code is safe, though, and it's definitely a bugfix. If it can't be backported, so be it, but it would be a pity. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
This looks fine to get it 👍 |
ellatrix
force-pushed
the
image/fix-aspect-ratio-button
branch
from
8d461c0 to
7cbf5ad
Compare
ellatrix
added
Backport to WP 6.6 Beta/RC
and removed
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: ellatrix <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 00633da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the position of the Aspect Ratio button in the block toolbar of the image block. This issue only occurs when the Top Toolbar is enabled.
Why?
This issue appears to have first appeared in WP6.5. It was probably caused by a styling change to the header block toolbar starting with #57444.
How?
Removed the styles specific to this button. These styles were added about 4 years ago in #23677. Maybe the styles don't fit the current block toolbar.
Testing Instructions