Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global styles revisions: ensure that user-defined variation styles CSS is generated #62768

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Global styles revisions: ensure that user-defined variation styles CSS is generated #62768

merged 10 commits into from
Jun 27, 2024

Commits on Jun 27, 2024

  1. Render styles after the variation style overrides have been saved to … 

    …stage.

Getting closer. But the overrides in state need to be merged with incoming revision styles.
    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    69b219e View commit details
    Browse the repository at this point in the history

  2. For every current override, update the variation CSS with the incomin… 

    …g config from the revision.
    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1b4e3c5 View commit details
    Browse the repository at this point in the history

  3. Rename hook 

    Destructure in hook so the consumer doesn't have to clone
Only send the override overrides to EditorStyles that need to be overridden.
    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5189486 View commit details
    Browse the repository at this point in the history

  4. Fetching overrides in the hook

    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3d583c8 View commit details
    Browse the repository at this point in the history

  5. Feedback suggestions from review: 

    add overrides to dep array in Editor Styles
rename hook
    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2853fb3 View commit details
    Browse the repository at this point in the history

  6. Return getBlockStyles from the useSelect callback

    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    375470e View commit details
    Browse the repository at this point in the history

  7. Refactor so we don't have to change the EditorStyles props 

    Register revision overrides with useStyleOverride
    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b9eb758 View commit details
    Browse the repository at this point in the history

  8. Adding some explanatory comments 

    Add rudimentary E2E test covering block style partials, applying them, updating them and viewing styles revisions.
    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fcebc07 View commit details
    Browse the repository at this point in the history

  9. Removed unused style fixture

    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2e3c9d8 View commit details
    Browse the repository at this point in the history

  10. Removed unused style fixture

    @ramonjd
    ramonjd committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    55cc60c View commit details
    Browse the repository at this point in the history