Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip on typography variations #62678

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

amitraj2203
Copy link
Contributor

What?

Extracted from this message

Why?

To improve the user experience by displaying the title of each typography variations when hovering over them in the site editor's global styles just like it happens with the theme colors.

How?

This PR adds tooltip to the typography variations in the site editor's global styles to display the title of each preset when hovered over.

Testing Instructions

  1. Go to site editor > styles
  2. Hover over a typography variation which is located at the end.

Screenshots or screencast

Screen.Recording.2024-06-20.at.1.32.33.AM.mov

@amitraj2203 amitraj2203 added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 19, 2024
Copy link

github-actions bot commented Jun 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <[email protected]>
Co-authored-by: scruffian <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, a shame we need the extra div but otherwise looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants