Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: Fix focus style not around whole image when linked #62556

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Image block: Fix focus style not around whole image when linked #62556

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a27516
Add inline-block display to image and media-text image
amitraj2203 Jun 13, 2024
876b713
Add display:block to image's <a> tag
amitraj2203 Jun 19, 2024
7b1a5d8
Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/issue…
amitraj2203 Jun 19, 2024
aae8bdc
Addressed feedback
amitraj2203 Jun 19, 2024
a6e2ba6
Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/issue…
amitraj2203 Jun 19, 2024
f380188
Fix linting
amitraj2203 Jun 19, 2024
5a6edd9
Change syntax for .wp-block-media-text__media a CSS
amitraj2203 Jun 20, 2024
6b5d225
Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/issue…
amitraj2203 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/block-library/src/image/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
.wp-block-image {

a {
display: inline-block;
}

img {
height: auto;
max-width: 100%;
Expand Down Expand Up @@ -27,6 +32,11 @@
text-align: center;
}

&.alignfull a,
&.alignwide a {
width: 100%;
}

&.alignfull img,
&.alignwide img {
height: auto;
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/media-text/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
&.has-media-on-the-right {
grid-template-columns: 1fr 50%;
}

&__media > a {
display: inline-block;
}
}

.wp-block-media-text.is-vertically-aligned-top {
Expand Down
Loading