-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rawHandling, pasteHandling for mixed content with blocks and classic #62545
fix rawHandling, pasteHandling for mixed content with blocks and classic #62545
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected], @saulyz. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @saulyz! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
@ellatrix need your eyes here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this was never caught earlier.
) Unlinked contributors: [email protected], saulyz.
Unlinked contributors: [email protected], saulyz.
Unlinked contributors: [email protected], saulyz.
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: e08c158 |
Unlinked contributors: [email protected], saulyz.
What?
The rawHandler and the pasteHandler had a naive check for the block existence. The test was looking for string "<!-- /wp:" existence in the content. When mixed content exist, this would give positive result and would try to parse blocks thus wrongfully interpreting and failing.
Why?
When we convert legacy content to blocks sometimes whole article or some parts silently fail. Clicking "convert to blocks" does nothing - everything stays the same. In the Editor view one could not distinguish a problem content and would not get any error.
How?
Not changing the overall logic or the process, instead refining the check further checking if parsing has resulted with the same 'core/freeform' block. If content parsing results with the same and single freeform, let's continue the content conversion (previously process would stop).
Testing Instructions
Adding test files to PR that illustrate the issue.
Testing Instructions for Keyboard
Screenshots or screencast