Update all ConfirmDialogs in the codebase to be size=medium
#62532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Task
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +75 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
nerrad
approved these changes
Jun 13, 2024
| @@ -77,6 +77,7 @@ export default function PostSwitchToDraftButton() { | |||
| onConfirm={ handleConfirm } | |||
| onCancel={ () => setShowConfirmDialog( false ) } | |||
| confirmButtonText={ confirmButtonText } | |||
| size="medium" | |||
There was a problem hiding this comment.
Separate from this PR, but I don't think this component is surfaced in the UI anymore (it's deprecated)?
There was a problem hiding this comment.
Good catch - I've removed the change from that component in 48469a2
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ess#62532) * Update all `ConfirmDialog`s in the codebase to be size=medium * Don't update deprecated dialog ---- Co-authored-by: talldan <[email protected]> Co-authored-by: nerrad <[email protected]> Co-authored-by: annezazu <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Update all `ConfirmDialog`s in the codebase to be size=medium * Don't update deprecated dialog ---- Co-authored-by: talldan <[email protected]> Co-authored-by: nerrad <[email protected]> Co-authored-by: annezazu <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Update all `ConfirmDialog`s in the codebase to be size=medium * Don't update deprecated dialog ---- Co-authored-by: talldan <[email protected]> Co-authored-by: nerrad <[email protected]> Co-authored-by: annezazu <[email protected]>
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 434e5c4 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Update all `ConfirmDialog`s in the codebase to be size=medium * Don't update deprecated dialog ---- Co-authored-by: talldan <[email protected]> Co-authored-by: nerrad <[email protected]> Co-authored-by: annezazu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #62524
Adds
size="medium"to theConfirmDialogs shown across gutenberg.Why?
Lots of the
ConfirmDialogusage across the codebase is very inconsistent. The dialog expands to the width of the text content, so some are very big, some are very small.How?
Add
size="medium"to anywhere we useConfirmDialog.It could also be added to the base component as an opinionated size, though it would be a breaking change.
There are unfortunately a lot of modals that look like a
ConfirmDialogin the codebase, but are actually reimplementing it. I haven't hunted every one down. I don't plan to completely address this issue, just make a reasonable attempt at bringing some consistency.Also, some of the
ConfirmDialogs that I changed I couldn't find a way to trigger. I don't think it's a big issue, this just changes themin-width.Testing Instructions
Screenshots or screencast