Extract the pattern overrides toolbar indicator from the block-editor package
#62514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Synced Patterns
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kevin940726
force-pushed
the
update/extract-pattern-overrides-toolbar-indicator
branch
from
9d15ee3 to
4859d0d
Compare
kevin940726
commented
Jun 12, 2024
There was a problem hiding this comment.
Moved to packages/patterns/src/components/pattern-overrides-block-controls.js.
There was a problem hiding this comment.
Moved to packages/patterns/src/components/style.scss.
|
Size Change: +474 B (+0.03%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jun 13, 2024
| @@ -43,6 +44,7 @@ const withPatternOverrideControls = createHigherOrderComponent( | |||
| { props.isSelected && isSupportedBlock && ( | |||
| <ControlsWithStoreSubscription { ...props } /> | |||
| ) } | |||
| { isSupportedBlock && <PatternOverridesBlockControls /> } | |||
There was a problem hiding this comment.
It's a shame there's no way to add a condition like ( props.isSelected || props.isMultiselected ) here
There was a problem hiding this comment.
We should probably add a comment there to avoid accidental regression.
talldan
approved these changes
Jun 13, 2024
kevin940726
deleted the
update/extract-pattern-overrides-toolbar-indicator
branch
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…r` package (WordPress#62514) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: talldan <[email protected]> * Extract pattern overrides toolbar indicator from the block-editor package * Fix error
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
…r` package (#62514) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: talldan <[email protected]> * Extract pattern overrides toolbar indicator from the block-editor package * Fix error
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
…r` package (#62514) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: talldan <[email protected]> * Extract pattern overrides toolbar indicator from the block-editor package * Fix error
|
I just cherry-picked this PR to the wp/6.6-beta-3 branch to get it included in the next release: 8d8f681 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 18, 2024
…r` package (#62514) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: talldan <[email protected]> * Extract pattern overrides toolbar indicator from the block-editor package * Fix error
Mamaduka
reviewed
Jul 5, 2024
Comment on lines
+143
to
+144
| hasPatternOverrides: _hasPatternOverrides, | ||
| hasParentPattern: _hasParentPattern, |
There was a problem hiding this comment.
I am unsure if this affects anything substantial, but these values will be true when selectedClientIds is an empty array. Do to how Array.every works in JS.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #60619. Address the issue discussed in #62317 (comment).
Extract out pattern overrides related code from the
block-editorpackage to thepatternspackage, specifically the toolbar indicator.Why?
Pattern Overrides is a WP-only feature so ideally it doesn't belong in the
block-editorpackage.How?
Create a
PatternOverridesBlockControlscomponent and conditionally render it using the pattern-overrides hook.Testing Instructions
Screenshots or screencast
Select a single pattern overrides block:
Select multiple pattern overrides blocks:
Select a block inside the pattern focus mode:
