[Mobile] - RichText - Fix undefined onDelete callback
#62486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Bug
2 tasks
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
# Conflicts: # packages/react-native-editor/CHANGELOG.md
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
) * Native RichText - Fix undefined onDelete callback * Update changelog Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]>
geriux
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Native RichText - Fix undefined onDelete callback * Update changelog Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]>
geriux
pushed a commit
that referenced
this pull request
Jun 19, 2024
* [Mobile] - Image corrector - Check the path extension is a valid one (#62190) * Mobile - Image corrector - Check the path extension is a valid one * [Mobile] - Image corrector- Expand comment explaining the filtering for file: media paths * Integration Test helpers - Expand pasteIntoRichText to support passing files as a parameter * Mobile Editor Tests - Add new tests related to pasting HTML content with local image paths * Update snapshot * [Mobile] - Unsupported block - UI improvements (#62240) * Mobile - Unsupported block editor - Update editor style overrides * Mobile - Unsupported block - Update UI to show Tap to edit for unsupported blocks, simplifying the flow to open the Unsupported block editor * Fix unsupported block condition * Update snapshot * Fix condition for the help icon * Update Unsupported Block Editor condition and reverts the functionality to select the block first before opening the editor. * Release script: Update react-native-editor version to 1.120.0 * Release script: Update CHANGELOG for version 1.120.0 * Release script: Update podfile * [Mobile] - RichText - Fix `undefined` onDelete callback (#62486) * Native RichText - Fix undefined onDelete callback * Update changelog Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]> * Release script: Update react-native-editor version to 1.120.1 * Release script: Update podfile --------- Co-authored-by: geriux <[email protected]> Co-authored-by: twstokes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
undefinedonDelete callback wordpress-mobile/gutenberg-mobile#6925What?
Fixes a crash when quickly deleting a Paragraph block and quickly focusing on a title and deleting it as well.
Why?
To prevent a crash in this case scenario when editing content.
How?
By adding a check for the
onDeletecallback in the RichText component.Testing Instructions
Note
Please use the following builds to test:
Testing Instructions for Keyboard
N/A
Screenshots or screencast
RichTextBefore.mov
RichTextAfter.mov