Placeholders: Fix contrast. #62416
Merged
Placeholders: Fix contrast. #62416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
@afercia I think this PR will fix one of the issues pointed out in this comment. I would appreciate it if you could review this PR. |
jasmussen
added
the
Backport to WP 6.7 Beta/RC
afercia
added
the
[Focus] Accessibility (a11y)
|
A reminder that Beta 2 is tomorrow, so we will be cherry-picking merged PRs labeled with "Backport to WP Beta/RC" today. |
|
Thanks for this PR. Although there's more into play with these 'variations picker' placeholders as detailed in #60206 and #60217, I think this PR solves the color contrast issue. Worth nothing the Group variations buttons don't show any text, which is less than ideal for a11y and it's inconsistent with other blocks. In this case I think we should consider the icons as 'large text' so that in this specific case the Current state in this PR: Group, Columns, Query blocks:
|
|
Appreciate the review. @vcanales this should be ready to backport. |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: jasmussen <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: vcanales <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: jasmussen <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: vcanales <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jasmussen <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: vcanales <[email protected]>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The icons in the placeholder don't meet 3:1 UI contrast:
With this PR, they do:
Testing Instructions
Insert group, columns, or other placeholders. The variation icons should have sufficient contrast.