Site Editor: Remove editor specific classes from shell wrapper. #62389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
commented
Jun 6, 2024
| @@ -457,12 +457,6 @@ $color-control-label-height: 20px; | |||
| } | |||
| } | |||
|
|
|||
| .has-fixed-toolbar .wp-block-navigation__responsive-container.is-menu-open { | |||
There was a problem hiding this comment.
I tested the navigation block, it's the only place where this has-fixed-toolbar was used but I didn't find that these styles had any meaningful impact.
There was a problem hiding this comment.
It's been a while, but I believe that these styles are probably related to when the overlay menu is open. It may be fine to remove if this still tests well, regardless there should be an incoming overlay-to-template-part PR that would most likely make it redundant.
There was a problem hiding this comment.
Yes, I tried this flow, and didn't notice any difference with or without the style.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -173 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
LGTM as I couldn't spot any differences from trunk. As a follow up we should probably consider removing some of these classes like is-distraction-free and conditionally render the components that are affected by such logic. Currently we do some conditional rendering and some css hiding..
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…Press#62389) Co-authored-by: youknowriad <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #62371
What?
As we start exploring building a site editor like experience for posts and media libraries... we need to ensure the "Layout" or "Shell" of the site editor is not opinionated about its content/pages...
With that in mind, this PR removes some class names from that wrapper (most of these classnames are applied appropriately to the editor wrapper or elsewhere) which I found to be useless.
Testing Instructions
1- Check the site editor.
2- Check the navigation block overlay in the site editor.