Revert changes to bindings replacement logic to not use regex

[SantosGuillamot]

What?

Revert the changes made in this pull request to avoid using regex that can cause potential bugs like this one.

Why?

The idea of that pull request was to simplify the logic to support more attributes, but, in the end, there is no plan to support more attributes for 6.6. As it is causing other problems, it seems it is better to revert it.

How?

Just reverting the changes made.

Testing Instructions

Follow the testing instructions of #62347 (comment) and check that the issue is solved.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SantosGuillamot <[email protected]>
Co-authored-by: kevin940726 <[email protected]>
Co-authored-by: talldan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/blocks.php

[kevin940726]

Thanks for the quick PR!

[github-actions]

Flaky tests detected in 806da8a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9396824098
📝 Reported issues:

• [Flaky Test] Redirection after template creation #60678 in /test/e2e/specs/site-editor/site-editor-url-navigation.spec.js

[talldan]

but that didn't make it to 6.6 and it is causing other problems, so it seems it is better to revert it.

I see it did make it and there's a core PR WordPress/wordpress-develop#6744.

Testing with both that and this PR checked, the revert works, but with only this one the block bindings code from core still causes the issue. I guess block bindings must be running twice when the gutenberg plugin is active.

[talldan]

Works for me too 🎉

[SantosGuillamot]

I see it did make it and there's a core PR WordPress/wordpress-develop#6744.

Oh sorry, I meant that the support of more attributes didn't make it in 6.6. I'll change the description for clarity.

Testing with both that and this PR checked, the revert works, but with only this one the block bindings code from core still causes the issue.

Do you mean that with WordPress trunk and this branch you still see the issue? I will double-check, but I think it wasn't the case for me.

[talldan]

Do you mean that with WordPress trunk and this branch you still see the issue? I will double-check, but I think it wasn't the case for me.

Yep, when debugging I could see that WP_Block->replace_html is being called on the content before gutenberg_block_bindings_replace_html.

[SantosGuillamot]

You're totally right. Anyway, with the backport in core I believe we should be fine.

Apart from that, I think we don't want to run gutenberg_block_bindings_replace_html if core is doing it. It should just act for older versions of WordPress. But I can work on that in another pull request.