Migrate theme.json based on origin

[ajlende]

What?

• Updates the API for WP_Theme_JSON_Schema_Gutenberg::migrate to accept an origin.
• Use the new origin argument to conditionally migrate changes in theme.json v3

Why?

See the discussion in https://github.com/WordPress/gutenberg/pull/61262/files#r1589940214

@oandregal

Perhaps we can absorb $config['isGlobalStylesUserThemeJSON'] = true; as part of WP_Theme_JSON_Data_Gutenberg. We may want to still check that's true before returning to be extra-safe (line 553) but we wouldn't need a second transformation.

@joemcgill

Looks like the $config['isGlobalStylesUserThemeJSON'] modification was made as part of 2012a36 (#58409).

@ajlende is there a reason why this would still be necessary if we use the WP_Theme_JSON_Gutenberg object already present in the WP_Theme_JSON_Data_Gutenberg object?

@ajlende

The $config['isGlobalStylesUserThemeJSON'] is required for migrations that don't need to run for the custom origin in WP_Theme_JSON_Schema::migrate (called on new WP_Theme_JSON()). If the origin could be passed to migrate in some other way, then it would be fine.

gutenberg/lib/class-wp-theme-json-schema-gutenberg.php

Lines 115 to 124 in cc2fcbe

	/*
	* Remaining changes do not need to be applied to the custom origin,
	* as they should take on the value of the theme origin.
	*/
	if (
	isset( $new['isGlobalStylesUserThemeJSON'] ) &&
	true === $new['isGlobalStylesUserThemeJSON']
	) {
	return $new;
	}

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/class-wp-theme-json-gutenberg.php
❔ lib/class-wp-theme-json-resolver-gutenberg.php
❔ lib/class-wp-theme-json-schema-gutenberg.php
❔ lib/experimental/kses.php

[oandregal]

I've left a comment to address and it seems this needs a rebase. But it's a really nice update. Thanks for the follow-up!

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ajlende <[email protected]>
Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[oandregal]

This is blocked by the performance test failures, which are unrelated and are being investigated at #62331

[oandregal]

Backport at WordPress/wordpress-develop#6737