Interactivity API: Fix null and number strings as namespaces runtime error. #61960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ packages/e2e-tests/plugins/interactive-blocks/namespace/render.php |
|
Size Change: +80 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
sirreal
reviewed
May 24, 2024
Comment on lines
+21
to
+27
| <div data-wp-interactive="null"> | ||
| <a data-wp-bind--href="state.url" data-testid="null namespace"></a> | ||
| </div> | ||
|
|
||
| <div data-wp-interactive="2"> | ||
| <a data-wp-bind--href="state.url" data-testid="number namespace"></a> | ||
| </div> |
There was a problem hiding this comment.
These would've had similar interesting behavior, all the JSON values:
<div data-wp-interactive="true"></div>
<div data-wp-interactive="false"></div>
<div data-wp-interactive="[]"></div>
<div data-wp-interactive='"my namespace is a quoted string"'></div>
sirreal
reviewed
May 24, 2024
packages/interactivity/src/vdom.ts
Outdated
| @@ -100,7 +100,8 @@ export function toVdom( root: Node ): Array< ComponentChild > { | |||
| const namespace = regexResult?.[ 1 ] ?? null; | |||
| let value: any = regexResult?.[ 2 ] ?? attributeValue; | |||
| try { | |||
| value = value && JSON.parse( value ); | |||
| const parsedValue = JSON.parse( value ); | |||
| value = isObject( parsedValue ) ? parsedValue : value; | |||
| } catch ( e ) {} | |||
There was a problem hiding this comment.
Nit: we can omit ( e ) when not using the error:
Suggested change
| } catch ( e ) {} | |
| } catch {} |
There was a problem hiding this comment.
Fixed in b7b6da8
cbravobernal
changed the title
cbravobernal
force-pushed
the
fix/iapi-runtime-namespace-crashing
branch
from
c7367ba
to
afb5f80
Compare
cbravobernal
requested review from
ntwb,
nerrad,
ajitbohra,
luisherranz and
DAreRodz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 4309428. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9253786308
|
sirreal
approved these changes
May 27, 2024
|
|
||
| store( 'null', { | ||
| state: { | ||
| url: '/some-url', |
There was a problem hiding this comment.
I'd like to see different values in the different stores. I think it's unlikely, but one could imagine falsy values evaluating to the same store.
There was a problem hiding this comment.
Done in 64e275d
TBH, I'm not 100% sure if we should allow this values to be namespaces 😅 |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…error. (WordPress#61960) * Fix null and number strings as namespaces runtime error * Update with suggestions * Update changelog * added wrong css changes * Revert move isObject to utils * Rename url vars Co-authored-by: cbravobernal <[email protected]> Co-authored-by: sirreal <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…error. (WordPress#61960) * Fix null and number strings as namespaces runtime error * Update with suggestions * Update changelog * added wrong css changes * Revert move isObject to utils * Rename url vars Co-authored-by: cbravobernal <[email protected]> Co-authored-by: sirreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Right now, creating a namespace called
nullor an integer24will kill the runtime.Why?
We are doing a JSON.parse() function that returns
nulltype ornumbertype if receivesnullornumberstrings.How?
By checking if it is an object.
Testing Instructions