-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global styles: relocate Background Image controls to sit under Layout #61886
Global styles: relocate Background Image controls to sit under Layout #61886
Conversation
- remove Background image top-level navigation item - relocate background panel to sit next to Layout controls
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -257 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Flaky tests detected in 15da58e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9200539505
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a good interim state for the feature. It allows it to ship, be iterated, and it's grouped with styles that are perhaps also not ideally placed, but nevertheless are related in a "global" context.
Notably it doesn't preclude future improvements and a clearer hierarchy, as we've discussed in other tickets.
Hi Ramon, just noting that the commit titles appear on #core slack, so we should try to make the commit titles a bit more comprehensible as much as we can when merging PRs. Thank you. |
Thanks for the ping @youknowriad This appears to be a limitation with the slack bot. I see that it only picked up the first line, but my commit message was sufficiently comprehensive in my opinion.
So that means we need to use one liners in our commit messages to appease the core slack bot 😆 |
Oh, the slack bot picks up the PR title. The title was always In any case I've added a comment in a thread in #core to elaborate. |
Definitely a bug in slack bot. Sorry for not noticing :) |
- remove Background image top-level navigation item - relocate background panel to sit next to Layout controls Co-authored-by: ramonjd <[email protected]> Co-authored-by: jasmussen <[email protected]>
- remove Background image top-level navigation item - relocate background panel to sit next to Layout controls Co-authored-by: ramonjd <[email protected]> Co-authored-by: jasmussen <[email protected]>
What?
This PR relocates the Background Image controls to sit under Layout in the global styles sidebar.
It also removes the Background image top-level navigation item.
Background image controls were originally added to global styles in #59454
There are no modifications to functionality.
Why?
The global styles taxonomy is under review and will likely change between now and WordPress 6.7.
See discussion:
The ambition in this PR is to make a low-impact change to the global styles taxonomy until these changes are implemented.
How?
Just movin' stuff around.
Testing Instructions
The main concern here is whether the location of Background controls, despite it being temporary, is a reasonable step and won't introduce too much confusion.
Furthermore, as no functionality is being introduced, it would be great to smoke test that the background controls work as they should, e.g.,
Screenshots or screencast