Visually hide 'Actions' column header #61710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -34 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d131ab7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9110078789
|
jasmussen
approved these changes
May 17, 2024
t-hamano
reviewed
May 20, 2024
There was a problem hiding this comment.
I believe this change should not cause any issues with accessibility.
One question, is <span className="dataviews-view-table-header"> still necessary? This class seems to add a small left padding, but the text is no longer visually present. If it is not needed, we may want to remove this span tag.
|
Good point, the |
Accessibility is not just about screen readers. This change goes in the opposite direction of some accessibility feedback previously reported on this old issue: #42505. A visible table header helps all users e.g. low vision users to draw their attention and identify the Actions column. The ellipsis button within the column is so thin that is hard to be seen for low vision users. A visible table header definitely helps. |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Visually hide the 'Actions' column header in data views table layout.
Why?
We can reduce some visual clutter in the top-right corner of the UI.
Unlike other column headers the 'Actions'
thdoesn't surface a menu on click, you can also argue that the items in this column are quite clearly actions, so the heading doesn't add a lot of value.The text is only hidden visually, so will still be announced by screen readers.