Remove onActionPerformed & onActionStart from the ActionModal API
#61659
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Code Quality
| /** | ||
| * The callback to execute when the action is triggered. | ||
| */ | ||
| onActionStart: ( ( items: Item[] ) => void ) | undefined; |
There was a problem hiding this comment.
Are these properties specific to modal actions or should they be moved to ActionBase
There was a problem hiding this comment.
I only see them in use by RenderModal https://github.com/WordPress/gutenberg/blob/trunk/packages/dataviews/src/item-actions.tsx#L119
There was a problem hiding this comment.
Makes sense. Given the names I think they can be supported in any type of action but since it follows our current implementation, it's fine to keep like that for now.
Follow-up to https://github.com/WordPress/gutenberg/pull/60805/files#r1599815188
What?
Removes
onActionPerformedandonActionStartfrom theActionModalAPI.Why?
Those are properties available at the action, so it's not necessary to pass them to the modal as well.