Remove default entry into Navigation Menu focus mode but retain ability to access via "Edit" #61275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Feature] Navigation Menus
getdave
requested review from
draganescu,
scruffian,
richtabor,
MaggieCabrera and
fabiankaegy
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +72 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
@scruffian @draganescu Will you be able to shepherd this over the line? I ask because I see a lot of movement happening in |
draganescu
approved these changes
May 3, 2024
| return { | ||
| key: 'styles', | ||
| key: 'navigation', |
There was a problem hiding this comment.
Typo from someone I expect. I've seen in corrected in other (yet to be merged) PRs.
|
Yeah this is a good compromise :) thanks :) |
Screen.Recording.2024-05-03.at.9.52.21.AM.movFound a bug when clicking on custom links. They open the link popover and then disappear from the list. Update: This is not related to this PR. It happens on Trunk too. |
draganescu
force-pushed
the
remove/navigation-focus-mode-by-default
branch
from
a95b5c1 to
32ab6a9
Compare
|
Flaky tests detected in 32ab6a9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8941146177
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the default behaviour of navigating to the navigation focus mode editor when clicking on a single Navigation Menu in the "Site Hub" (left hand black sidebar). Instead remains showing the full editor canvas.
Retains the ability to access the navigation menu focus mode via a new
Editoption to the Navigation Menu's options.This PR is an alternative to #59340. I did try to work on that PR but it had diverged from
trunkand so - having confirmed with @draganescu - it made sense to start afresh.Co-authored-by: Andrei Draganescu [email protected]
Co-authored-by: Rich Tabor [email protected]
Why?
During the discussion in #59340 contributors raised valid concerns regarding the utility of the focused navigation menu edit mode. Principally some contributors utilise this to edit menus which are not currently used within a Template (which incidentally is exactly why it exists!).
Therefore this PR does not remove the ability to edit a Navigation Menu in the focused editor mode, but rather deprioritises it in the default UX of interacting with
Navigationin the Site Hub sidebar.How?
Now when clicking on a single Navigation Menu you are shown the details of that menu in the siderbar but the editor canvas does not enter "focus mode". This avoids the confusion that has been associated with this view which is really aimed at more advanced use cases.
The ability to access the Navigation Menu in focus mode is retained via the addition of an
Editlink in the Navigation Menu's options menu.Testing Instructions
Editoption.Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-05-01.at.10-59-07.mp4