Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary period in template block selection notice #61087

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Remove unnecessary period in template block selection notice #61087

merged 1 commit into from
Apr 26, 2024

Conversation

itzmekhokan
Copy link
Contributor

Fixes a bug raised here #61053

What?

A unnecessary point at the end of the sentence.

You’ve tried to select a block that is part of a template, which may be used on other posts and pages. Would you like to edit the template?->.<-

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: itzmekhokan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 25, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @itzmekhokan! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Apr 25, 2024
Mamaduka
Mamaduka approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @itzmekhokan!

@talldan talldan changed the title Fix typo for ticket 61053 Remove unnecessary period in template block selection notice Apr 26, 2024
@talldan talldan linked an issue Apr 26, 2024 that may be closed by this pull request
typo - build/editor/index.js #61053
Closed
@talldan talldan merged commit d89e5a8 into WordPress:trunk Apr 26, 2024
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 26, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Apr 26, 2024
@itzmekhokan @t-hamano
@Mamaduka @huubl
Remove unnecessary period in template block selection notice (WordPre…
e1f77e1 
…ss#61087)

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: timse201 <[email protected]>
Co-authored-by: itzmekhokan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 18.3
Development

Successfully merging this pull request may close these issues.

typo - build/editor/index.js
3 participants
@itzmekhokan @Mamaduka @talldan