Decode HTML entities in success notices on the Pages screen #61086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodes HTML entities in the post and page titles in the success notices when creating a new page and duplicating a post or page via the Site Editor Pages screen.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -35 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
carolinan
commented
Apr 25, 2024
packages/edit-site/src/components/sidebar-edit-mode/page-panels/index.js
Show resolved
Hide resolved
carolinan
added
[Type] Bug
carolinan
changed the title
|
Flaky tests detected in 84f2457. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8999742592
|
|
The merge conflicts are too large to save this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Decodes HTML entities in the post and page titles in the success notices that shows when creating a new page through the Site Editor, and when duplicating a post or page via the Site Editor Pages screen or the block editor.
Note: This meant adding "@wordpress/html-entities" to the
edit-postpackage.Partial for #60995
Why?
When a page or post title has HTML entities like
&in the post title, these success notices displayed the characters as encoded. So&displayed as&.How?
Wrap the titles inside
decodeEntitieshttps://developer.wordpress.org/block-editor/reference-guides/packages/packages-html-entities/#decodeentitiesTesting Instructions
Screenshots or screencast