Rich text: combine all ref effects #60936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
force-pushed
the
try/rich-text-combine-ref-effects
branch
from
034f2c6 to
bf1c0af
Compare
|
Size Change: -41 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/rich-text-combine-ref-effects
branch
from
b7ef3d7 to
c373832
Compare
|
Merging this because it's just a refactor and I have some other PRs that touch these listeners. Regardless of any perceivable performance benefit, I think it make each listener also less verbose and more understandable. |
ellatrix
commented
May 1, 2024
| ( element ) => { | ||
| if ( ! props.isSelected ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Additionally this PR avoids attaching all these listeners for non selected blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Instead of calling
useRefanduseRefEffect(which consists of anotheruseRefanduseCallbackcall) 17 times for a single rich text instance, we can reuse the same ref and callback to add all event listeners.Why?
Reduces the amount of React hooks in rich text, and the verbosity.
How?
We can use a single ref effect to attach all the event listeners.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast