Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Extra Space Before Since #60918

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Removed Extra Space Before Since #60918

merged 1 commit into from
Apr 20, 2024

Conversation

shail-mehta
Copy link
Member

Fixes: #60917

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta mentioned this pull request Apr 19, 2024
Closed
@t-hamano t-hamano self-requested a review April 20, 2024 04:50
t-hamano
t-hamano approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A similar modification would also be required in the core.

https://github.com/WordPress/wordpress-develop/blob/e21aa8a17d63721feeba1063494237bac9791927/src/wp-includes/class-wp-block-bindings-registry.php#L15

Are you interested in submitting a core ticket and a patch?

P.S. If you don't make "Fixes:" bold, the issue and PR will be automatically linked and the issue will be closed when the PR is merged.

@t-hamano t-hamano linked an issue Apr 20, 2024 that may be closed by this pull request
Extra Space need to remove in class-wp-block-bindings-registry.php file #60917
Closed
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality props-bot Adding this label triggers the Props Bot workflow for a PR. labels Apr 20, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 20, 2024
@t-hamano t-hamano merged commit 55a9e19 into WordPress:trunk Apr 20, 2024
64 of 66 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 20, 2024
@shail-mehta
Copy link
Member Author

shail-mehta commented Apr 20, 2024 •
edited
Loading

@t-hamano Thanks.

I have Created Ticket & added patch in Core: https://core.trac.wordpress.org/ticket/61046

For "Fixes:" bold : Noted , I will take care of this in Next time

@shail-mehta shail-mehta deleted the remove-extra-space branch May 5, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 18.3
Development

Successfully merging this pull request may close these issues.

Extra Space need to remove in class-wp-block-bindings-registry.php file
2 participants
@shail-mehta @t-hamano