Editor: Unify the region navigation keyboard shortcuts #60907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -87 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/unify-region-navigation-shortcuts
branch
from
6f07599
to
7f58c76
Compare
Indeed it doesn't seem to work for me either.
The design of the widget editor is very different than site or post editors: It's not about editing one entity, it's about using a specific layout to edit multiple entities at the same time. Which basically means the "@wordpress/editor" abstraction is not well fit for it. That said (and this is just my opinion), I believe we should treat the widget areas just like template parts and move it to the site editor ultimately rather than having a special editor 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This unifies the region navigation keyboard shortcuts between the post and site editors. We register these shortcuts in the editor package for now.
Testing Instructions
1- You can use
ctrl + option + nto navigate editor regions in both post and site editors.