Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: Fix modal scrollbar #60641

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Font Library: Fix modal scrollbar #60641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eeb493
Make footer a fixed height; add margin to modal content
mikachan Apr 10, 2024
c936361
Remove Spacer from bottom of Library tab content
mikachan Apr 10, 2024
e5a985f
Add variable for footer height size
mikachan Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/edit-site/src/components/global-styles/font-library-modal/installed-fonts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ function InstalledFonts() {
) ) }
</>
) }
<Spacer margin={ 16 } />
Copy link
Member Author

@mikachan mikachan Apr 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was added to create some space between the content and the footer. I don't think this is needed now that it's possible to see the bottom of the content above the footer.

</NavigatorScreen>

<NavigatorScreen path="/fontFamily">
Expand Down
6 changes: 6 additions & 0 deletions packages/edit-site/src/components/global-styles/font-library-modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Fixed height for the modal footer.
// Ensures that the footer is always visible when the modal content is scrollable.
$footer-height: 70px;

.font-library-modal {
// @todo If a new prop is added to the Modal component that constrains
// the content width, we should use that prop instead of this style.
Expand All @@ -15,6 +19,7 @@

.components-modal__content {
padding-top: 0;
margin-bottom: $footer-height;
}

.font-library-modal__subtitle {
Expand All @@ -40,6 +45,7 @@
position: absolute;
bottom: $grid-unit-40;
width: 100%;
height: $footer-height;
background-color: $white;
}
}
Expand Down
Loading