CustomSelectControlV2: Stabilize tests #60133
Conversation
mirka
added
[Type] Automated Testing
|
|
||
| await type( 'aq' ); |
There was a problem hiding this comment.
Apparently the multi-character typeahead is causing the flakiness. I think it'd be an acceptable compromise to test only a single-character typeahead.
There was a problem hiding this comment.
Is it worth adding an inline comment here, and in the non-legacy component test, flagging this as deliberately avoiding the multi-character typeahead?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| await type( 'aq' ); |
There was a problem hiding this comment.
Is it worth adding an inline comment here, and in the non-legacy component test, flagging this as deliberately avoiding the multi-character typeahead?
* CustomSelectControlV2: Stabilize tests * Add comments Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
* CustomSelectControlV2: Stabilize tests * Add comments Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
What?
Stabilizes the flakiness we've been seeing in the unit tests for CustomSelectControlV2.
How I tested
✅ Consistently passes in chunks of 50 repeated isolated tests (Whereas previously, it would consistently fail)