Social icons: only render label container when there's a label #60060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
the
[Block] Social
Use the default label instead.
ramonjd
force-pushed
the
update/social-icons-label-hide-if-empty
branch
from
269d340 to
9668712
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 21, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ress#60060) * Use the default label in the `wp-block-social-link-label` span if there is no label content. * Setting label attribute to `undefined` not empty string, as it will pass `isset` PHP checks. * Removed unnecessary parentheses Co-authored-by: ramonjd <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: afercia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? How?
Checks for label content before rendering a
wp-block-social-link-labelspan using! empty( $attributes['label'] ).Also as a double precaution, setting the label attribute to
undefinedinstead of''.If there's no label, render the default in the frontend.
Why?
To avoid rendering an empty
wp-block-social-link-labelspan on the frontend.Empty strings will pass PHP's
issetcheck.Testing Instructions
<span class="wp-block-social-link-label screen-reader-text">Mail</span><span class="wp-block-social-link-label screen-reader-text"/>should contain the default label from the $services_data arrayTest HTML