-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace screenshots of Radio Control #60024
Conversation
As discussed in WordPress#28763.
I see! From what I can tell from the docs and actual behavior though, the new file access restrictions are only for private repositories, not public ones like Gutenberg. The URLs we get are now For example, I attached your images to this comment, and the URLs should be accessible in an Incognito tab without authentication:
We are starting to use more GitHub hosted images for our docs, since it's a lot easier to maintain. |
Thank you @mirka, I just tried it with the dynamic generated URLs. With the static "permalinks" everything works fine. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @lmartins. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you for the quick responses!
* Replace screenshots of Radio Control As discussed in WordPress#28763. * Use GitHub permalinks and add alt text Unlinked contributors: lmartins. Co-authored-by: krokodok <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: dhruvkb <[email protected]> Co-authored-by: ryanwelcher <[email protected]> Co-authored-by: benlk <[email protected]>
What?
Replacing screenshots showing a wrong component with the right one, as discussed in #28763.
Please help
Could someone take my two files
and upload them to the make.wordpress.org server and then change the URLs in the README file? I looked through the repository into other README documents, and there do not seem to be other cases of GitHub hosted images.
Also, since the last time I commented on the original issue with screenshots, GitHub changed the visibility of GitHub hosted images. Because I created new screenshots today, that contain the big, coloured "Right" and "Wrong" indicators, I can't "host" them on GitHub via a comment on the issue, as previously. The files now live inside a branch in my fork, which is not optimal, since this could be deleted some day!
Why?
The old screenshot was not showing the RadioControl component but a custom one instead.
How?
The screenshots are replaced.
Testing Instructions
n/a
Testing Instructions for Keyboard
n/a
Screenshots or screencast
Old
New