Use correct layout type to display controls. #59979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Mar 19, 2024
andrewserong
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Nice fix, this is testing well for me, too! ✨
Fixes an issue I encountered in working on #42240.
I just noticed that issue describes switching over to grid instead of flex, but I'm wondering if it'd be better to allow both, with the option to switch between them, since grid and flex can offer slightly different styling possibilities? I'll leave a comment over on that issue since it's not related to this PR 🙂
Edit: added a comment over here: #42240 (comment)
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: tellthemachines <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue I encountered in working on #42240.
When a block's default layout type is set to anything other than "default" or "constrained", the
allowInheritingproperty should have no effect. But because we were only checking the layout's type inlayout.typeand not inlayout.default.type, other default layout types were not being evaluated correctly, and were depending on explicitly settingallowInheritingtofalsein the block.json in order to hide the "Inner blocks use content width" toggle.It should not be necessary to set
allowInheritingexplicitly when adding a default flex or grid layout type to a block.Testing Instructions
"allowInheriting": false,from the layout config in packages/block-library/src/buttons/block.json.