Improve likelihood of Cherry Picking script including all PRs #59871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improves the liklihood that the Cherry Picking script will fetch all the PRs that need to be cherry picked.
Closes #59210
Why?
The Github API paginates it's results with a default of 30. It is possible that for a given release there will be more than 30 PRs that need to be picked into the relevant release branch.
This needs fixing so that future release leads don't end up missing PRs. I already updated the release docs with this extra warning but it makes sense to also improve the tooling.
How?
Adds the
per_page
param to the request and sets it to100
.I see this as a "good enough" fix. If there are more than 100 PRs in a given release we have a bigger problem 😆
Testing Instructions
npm run other:cherry-pick -- "[Type] Bug"
.Testing Instructions for Keyboard
Screenshots or screencast