Update block supports documentation for WordPress 6.5 #59862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/reference-guides/block-api/block-supports.md # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # interactive rebase in progress; onto 08f14e9 # Last command done (1 command done): # pick 7cef11a9792 WordPress#59735 add wp 6.5 block supports # Next command to do (1 remaining command): # pick 49f7ce51882 block supports: fix formatting + consistency # You are currently rebasing branch 'docs/block-supports-update-6.5' on '08f14e9896d'. # # Changes to be committed: # modified: docs/reference-guides/block-api/block-supports.md # modified: schemas/json/block.json # # Untracked files: # .vscode/launch.json # .vscode/settings.json #
gaambo
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
added
the
[Type] Developer Documentation
fabiankaegy
approved these changes
Mar 15, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: gaambo <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59735 by adding the new block supports do documentation. I've mostyl taken the descriptions from the
block.jsonschema file and used the dev note.aspectRatiowas already documented under dimensions.Additionally:
Why?
How?
I've got prettier configured as described here and hope that the formatting is correct. Prettier actually tries to add semicolons to all JSON code snippets (because their language is JS), but I removed them manually.
Running
npm run lint:md:docs docs/reference-guides/block-api/block-supports.mdnow does not yield any errors. If you want to split the formatting into a separate PR, let me know.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast