Prevent default on primary+k to prevent command center from opening on navigation link #59845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command center shortcut checks for defaultPrevented to see if it should open or not. To prevent the command center from opening, we need to add event.preventDefault when primary+k is used.
jeryj
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
the
Backport to Gutenberg RC
|
Size Change: +2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Mar 13, 2024
andrewserong
added
Backport to WP 6.7 Beta/RC
|
Hi folks, I see the |
youknowriad
reviewed
Mar 14, 2024
| @@ -333,6 +333,7 @@ export default function NavigationLinkEdit( { | |||
| isKeyboardEvent.primary( event, 'k' ) || | |||
| ( ( ! url || isDraft || isInvalid ) && event.keyCode === ENTER ) | |||
| ) { | |||
| event.preventDefault(); | |||
There was a problem hiding this comment.
It would be cool to add some inline comments to explain why we needed the prevent default.
Just noting that regardless of whether this was intended, I would like to retain the I think we should include this in WordPress 6.5 during the RC period. |
youknowriad
pushed a commit
that referenced
this pull request
Mar 18, 2024
…59845) The command center shortcut checks for defaultPrevented to see if it should open or not. To prevent the command center from opening, we need to add event.preventDefault when primary+k is used.
|
I just cherry-picked this PR to the update/packages-rc2-6.5 branch to get it included in the next release: 31ac517 |
youknowriad
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Mar 18, 2024
…59845) The command center shortcut checks for defaultPrevented to see if it should open or not. To prevent the command center from opening, we need to add event.preventDefault when primary+k is used.
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ordPress#59845) The command center shortcut checks for defaultPrevented to see if it should open or not. To prevent the command center from opening, we need to add event.preventDefault when primary+k is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59839
The command center shortcut checks for defaultPrevented to see if it should open or not. To prevent the command center from opening, we need to add event.preventDefault when primary+k is used.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast