Interactivity API: Fix interactivity api e2e tests. #59836
Conversation
cbravobernal
added
[Type] Bug
cbravobernal
requested review from
spacedmonkey,
ntwb,
nerrad and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * Uses a priority of 100 to ensure that other filters can add additional | ||
| * directives before the processing starts. | ||
| */ | ||
| add_filter( 'render_block_' . $block_name, $process_interactive_blocks, 100, 2 ); |
| /* | ||
| * Uses a priority of 100 to ensure that other filters can edit $parsed_block | ||
| * without crashing the SSR. | ||
| */ | ||
| add_filter( 'render_block_data', 'wp_interactivity_process_directives_of_interactive_blocks', 100 ); |
There was a problem hiding this comment.
core has 1 as the last argument here, although I think that's the default and maybe it should be omitted in core.
There was a problem hiding this comment.
Yes it should be omitted, pointless to add the default
|
I think this PR probably should have been backported to |
getdave
added
the
Backport to WP 6.7 Beta/RC
* Use same prioprity than in Core * Backport priority filter * Add argument Co-authored-by: c4rl0sbr4v0 <[email protected]> Co-authored-by: sirreal <[email protected]>
|
I just manually cherry picked this PR into the |
getdave
added
Backported to WP Core
bph
added
[Feature] Interactivity API
* Use same prioprity than in Core * Backport priority filter * Add argument Co-authored-by: c4rl0sbr4v0 <[email protected]> Co-authored-by: sirreal <[email protected]>
What?
Update the priority of removing the SSR for e2e tests to the number according to the current Core one.