Add tooltip to several Back buttons. #59760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
requested review from
talldan,
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -32 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/back-button-missing-tooltip
branch
from
4ff0671 to
8009caa
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: afercia <[email protected]> Co-authored-by: alexstine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59758
What?
Many 'back' icon buttons miss a tooltip.
Why?
All icon buttons must visually expose their accessible name.
How?
aria-labeltolabelto make the buttons render their built-in tooltip.Navigate to the previous viewto a simplerBack:Navigate to the previous viewmay help screen reader users (though a little verbose), speech recognition software users wouldn't have any clue a chevron left icon button name isNavigate to the previous view.Testing Instructions
Test some of the following 'back' icon buttons with a left chevron. Hover or focus them and observe they do show a tooltip.
Testing Instructions for Keyboard
Screenshots or screencast