Cherry Pick changes for WordPress 6.5 RC2 #59756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add failing test * Fix returned proxy reference * Add more reference tests * Fix assignment of context objects * Update comment * Update changelog Co-authored-by: DAreRodz <[email protected]> Co-authored-by: c4rl0sbr4v0 <[email protected]>
…variants (#59066) * Font Library: Load/Unload the font face in browser when toggling the variants * Font Library: Unload the deleted font faces * Address feedback * replace repeated implementation by the use of a existing fuction * remove inaccurate comment * added a formatFontFace call to be able to match fonts in firefox too. --------- Co-authored-by: Matias Benedetto <[email protected]> --- Co-authored-by: arthur791004 <[email protected]> Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: okmttdhr <[email protected]>
Fix erroneous escaping of ampersands to `u0026amp;`.
This is done by using the [`rest_pre_insert_{$this->post_type}`](https://developer.wordpress.org/reference/hooks/rest_pre_insert_this-post_type/) _filter_ rather than the `rest_insert_wp_navigation` _action_. This avoids calling `wp_update_post` twice, which was the original reason of the issue, as it removed the backslash from the already-encoded entity.
Unlinked contributors: kylekelly.
Co-authored-by: ockham <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: tjcafferkey <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: youknowriad <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: andrewserong <[email protected]>
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: rcoll <[email protected]>
A typo in font uploader string Co-authored-by: mujuonly <[email protected]>
Co-authored-by: ellatrix <[email protected]> Co-authored-by: andrewserong <[email protected]>
…from the home page (#59639) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: getdave <[email protected]>
…#59647) Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: SaxonF <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: sunil25393 <[email protected]>
Unlinked contributors: oldrup. Co-authored-by: ellatrix <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: timnolte <[email protected]> Co-authored-by: justintadlock <[email protected]> Co-authored-by: dmsnell <[email protected]>
Co-authored-by: talldan <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: getdave <[email protected]>
…ted (#59564) Co-authored-by: pbking <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: peterwilsoncc <[email protected]> Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mikachan <[email protected]>
Co-authored-by: jameskoster <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: annezazu <[email protected]> # Conflicts: # packages/dataviews/src/style.scss
…59708) Ensure scope is properly restored when an exception is thrown in a generator callback. For example, the following block should have the correct context in the catch block: try { yield Promise.reject( '💥' ); } catch ( err ) { getContext().error = err; } --- Co-authored-by: sirreal <[email protected]> Co-authored-by: DAreRodz <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: anton-vlasenko <[email protected]> # Conflicts: # packages/interactivity/CHANGELOG.md
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/blocks/block-navigation-block-hooks-test.php ❔ lib/load.php ❔ lib/compat/wordpress-6.6/block-bindings/pattern-overrides.php |
This comment was marked as resolved.
This comment was marked as resolved.
getdave
added
[Type] Task
|
Size Change: +907 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
… being uploaded are valid font files. (#59648) * Font Library: check if file upload is valid font Fixes: #59578 Refactors the upload handler in order to check if files being uploaded are valid font files. * make sure error message is relevant * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * Update packages/edit-site/src/components/global-styles/font-library-modal/upload-fonts.js Co-authored-by: Peter Wilson <[email protected]> * error message syntax * use WordPress yoda condition * Respect string freeze * Fix lint --------- Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Dave Smith <[email protected]>
* PoC * Fix cmd + K with click * Adding mutually exclusive states * Sync internal state with format active state * Fix broken anchors for Links * Improve variable naming * Normalize more variable names * Fix sub formats breaking click to edit * Force constrainedTabbing for link ui * Handle nested formats * Revert change to hasLink var * Locate const at top of file * Improve comment * Add test for editing text * Improve var naming * Correct comments * Make new prop unstable * Revert useAnchor API --------- Co-authored-by: getdave <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: bacoords <[email protected]> Co-authored-by: joedolson <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
* don't set creating menu flag on menu switch * return Promises from the navigation menu ref changing functions to be able to clean state after ref is updated * update tests * await the menu creation * stub test updates * revert test changes and remove decorative promises * do not disable the UI when changing the navigation, disable the UI based on resolving menus * block the UI for menu switching too, update tests with some comments, undo the focus update * properly disable menu choices via their choices prop Co-authored-by: draganescu <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: afercia <[email protected]> # Conflicts: # packages/block-library/src/navigation/edit/test/navigation-menu-selector.js
getdave
requested review from
spacedmonkey,
ellatrix,
fluiddot,
dcalhoun,
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra,
luisherranz,
DAreRodz and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@youknowriad I've now finished the cherry picking. Please could you review the PR and merge when you are happy? |
…59769) Co-authored-by: ntsekouras <[email protected]> Co-authored-by: youknowriad <[email protected]>
youknowriad
approved these changes
Mar 12, 2024
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 12, 2024
It includes all the backports from this Gutenberg PR WordPress/gutenberg#59756 Props get_dave, swissspidy, bernhard-reiter, youknowriad. See #60315. git-svn-id: https://develop.svn.wordpress.org/trunk@57814 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Mar 12, 2024
It includes all the backports from this Gutenberg PR WordPress/gutenberg#59756 Props get_dave, swissspidy, bernhard-reiter, youknowriad. See #60315. Built from https://develop.svn.wordpress.org/trunk@57814 git-svn-id: http://core.svn.wordpress.org/trunk@57315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Mar 12, 2024
It includes all the backports from this Gutenberg PR WordPress/gutenberg#59756 Props get_dave, swissspidy, bernhard-reiter, youknowriad. See #60315. Built from https://develop.svn.wordpress.org/trunk@57814 git-svn-id: https://core.svn.wordpress.org/trunk@57315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 12, 2024
It includes all the backports from this Gutenberg PR WordPress/gutenberg#59756 Reviewed by swissspidy. Merges [57814] to the to the 6.5 branch. Props get_dave, swissspidy, bernhard-reiter, youknowriad. See #60315. git-svn-id: https://develop.svn.wordpress.org/branches/6.5@57816 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 12, 2024
It includes all the backports from this Gutenberg PR WordPress/gutenberg#59756 Reviewed by swissspidy. Merges [57814] to the to the 6.5 branch. Props get_dave, swissspidy, bernhard-reiter, youknowriad. See #60315. Built from https://develop.svn.wordpress.org/branches/6.5@57816 git-svn-id: http://core.svn.wordpress.org/branches/6.5@57317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cherry picking commits proposed for WP 6.5 RC 2.
Automated
saveshortcut #59647IS_GUTENBERG_PLUGINflag #59702Manual
Why?
Release workflow
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast