Refine include/exclude patterns in phpcs.xml.dist #59712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-vlasenko
force-pushed
the
fix/phpcs-xml-dist-php-extension
branch
3 times, most recently
from
1abba1a to
cd91a11
Compare
Make regexp patterns more distinrns with /. 1. Don't use . before / in exclude/include pattern as it doesn't change anything. 2. Prepend exclude/include patterns with /.
anton-vlasenko
force-pushed
the
fix/phpcs-xml-dist-php-extension
branch
from
2a51c44 to
61d2a6f
Compare
anton-vlasenko
changed the title
anton-vlasenko
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
anton-vlasenko
requested review from
ironprogrammer,
dmsnell,
hellofromtonya,
azaozz,
aristath and
scruffian
ironprogrammer
approved these changes
Mar 15, 2024
scruffian
approved these changes
Mar 15, 2024
|
Thank you for the review and approval, @ironprogrammer and @scruffian! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ordPress#59712) 1. removed unnecessary dots at the start of include/exclude patterns; 2. added leading slashes to patterns to ensure they match the intended paths without accidentally including unintended ones; 3. escaped dots as `\.` to match literal dots in file paths, enhancing the precision of the patterns, as advised by PHP_CodeSniffer's [documentation](https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-files-and-folders); 4. added `$` to the end of patterns targeting `.php` files to ensure they match only at the end of file paths. Co-authored-by: anton-vlasenko <[email protected]> Co-authored-by: ironprogrammer <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: azaozz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refines patterns used in
<exclude-pattern>and<include-pattern>statements.Why?
According to the documentation on ignoring files and folders, the patterns in include/exclude statements are essentially regular expressions.
Therefore, beginning a pattern with a
.(dot) is redundant since.doesn't match the root folder.How?
\.to match literal dots in file paths, enhancing the precision of the patterns, as advised by PHP_CodeSniffer's documentation;$to the end of patterns targeting.phpfiles to ensure they match only at the end of file paths.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast