Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Fix PHP file change detection logic #59653

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 7, 2024

This issue was discovered by a bot comment below:

#59531 (comment)

What?

This PR fixes an issue where GitHub Actions that prompt PHP backports to core could unintentionally detect non-PHP files.

Why?

The lib and phpunit directories contain more than just php files.

Testing Instructions

This regular expression should be correct, but you can test it by modifying and pushing the files in the lib, phpunit directories in this PR.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended GitHub Actions Pull requests that update GitHub Actions code labels Mar 7, 2024
@t-hamano t-hamano self-assigned this Mar 7, 2024
@t-hamano t-hamano requested a review from ramonjd March 7, 2024 03:47
@t-hamano t-hamano marked this pull request as ready for review March 7, 2024 03:47
@t-hamano t-hamano requested a review from desrosj as a code owner March 7, 2024 03:47
Copy link

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: desrosj <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching all files was intentional just in case there were any .md files or other items that might need a Core patch, but it is a bit of an overkill.

This LGTM

🙇🏻

t-hamano and others added 2 commits March 7, 2024 14:24
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @t-hamano!

@desrosj desrosj merged commit 9e8d74c into trunk Mar 9, 2024
58 checks passed
@desrosj desrosj deleted the fix/php-changes-detection branch March 9, 2024 00:53
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 9, 2024
@bph bph added the [Type] Build Tooling Issues or PRs related to build tooling label Mar 21, 2024
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Bug, [Type] Build Tooling, GitHub Actions.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants