-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: Fix PHP file change detection logic #59653
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching all files was intentional just in case there were any .md
files or other items that might need a Core patch, but it is a bit of an overkill.
This LGTM
🙇🏻
Co-authored-by: Jonathan Desrosiers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @t-hamano!
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
This issue was discovered by a bot comment below:
#59531 (comment)
What?
This PR fixes an issue where GitHub Actions that prompt PHP backports to core could unintentionally detect non-PHP files.
Why?
The
lib
andphpunit
directories contain more than just php files.Testing Instructions
This regular expression should be correct, but you can test it by modifying and pushing the files in the
lib
,phpunit
directories in this PR.