Add custom placeholder icon

[ajitbohra]

Description

Currently Placeholder component does not support custom icon like IconButton. Allowing custom icon will make the component more flexible.

How Has This Been Tested?

Manually

Screenshots (jpeg or gifs if applicable):

Types of changes

Nonbreaking component change

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code has proper inline documentation.

[aduth]

Nice 👍

Evidenced by this bug, maybe we need future consolidation of this logic into an "Icon" component. Not necessary, but an idea.

[ajitbohra]

@aduth same thought Icon Component to dry the icons implementation. Will also help in code consistency have identified few places which can be refactored. Planning to work on the PR for the same.

[ajitbohra]

@aduth

Was looking to drying up Icon:

Currently, we are allowing the custom icon for:

• ButtonIcon
• Placeholder
• BlockIcon

Have noticed we already have a reusable component for the same BlockIcon either we can use this or rename it to Icon to be more generic and refactoring code referencing it. Also, we can move it to Components your thoughts.

[aduth]

Yeah, good call, BlockIcon looks like it could easily be generalized as Icon. There's nothing block-specific about it. Moving to components sounds reasonable. Since it's exposed as part of the public interface, we could either keep it (as a simple pass-through to Icon) or deprecate it.

[ajitbohra]

@aduth deprecating it sounds much better will work on the initial PR