Block Preview: Optimize default additional styles #59556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR suggests that in
BlockPreviewwe always default to the same empty array foradditionalStylesif no other styles are specified.This is a complement to #58244.
Why?
Currently, every
BlockPreviewrerender without specifiedadditionalStyleswill cause a rerender, becauseadditionalStyleswill then default to a new array. Even after #58244 this continues to be a problem because a new fresh empty array will be passed fromBlockPreviewtoAutoHeightBlockPreviewon every rerender when the block preview has no additional styles.I don't see a major performance impact, but this is still worth doing since this affects most block previews as they don't have additional styles.
How?
We're defaulting to the same empty array.
Similar to #58244, but for the parent component.
Potential follow-up: reusing the same
EMPTY_ADDITIONAL_STYLESfor both components.Testing Instructions
Verify block previews work still well for the inserter and patterns.
Testing Instructions for Keyboard
None
Screenshots or screencast
None