Navigation Link UI: Focus the parent block when a block is removed. #59466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +56 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
scruffian
changed the title
scruffian
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I think focus should be applied to the inserter in this instance and not the parent block. This is definitely better than the trunk experience of a total focus loss, but it would be best to return focus to where it previously was (on the inserter). |
|
When you click "Browse all" in the link UI to select another block this change now closes the inserter, which is bad. |
alexstine
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
@scruffian Thanks for the PR.
I agree with @jeryj . Focus should be placed on the Add block button. However, if that is not possible, this PR is totally reasonable and fixes a pretty bad regression.
Leaving an approve as this currently is an improvement.
|
Merging this as we don't have a better option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a Navigation Link block is removed, focus the parent block.
Fixes #58820
Why?
We don't want to cause focus-loss by removing this block.
How?
Get the clientId of the parent block and then select it.
Testing Instructions
Screenshots or screencast
Feb-29-2024.17-44-25.mp4