Block Editor: Don't memoize callbacks in 'BlockSettingsDropdown' #59397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Feb 27, 2024
| @@ -233,7 +224,7 @@ export function BlockSettingsDropdown( { | |||
| canRemove | |||
| ) { | |||
| event.preventDefault(); | |||
| updateSelectionAfterRemove( onRemove() ); | |||
| updateSelectionAfterRemove(); | |||
There was a problem hiding this comment.
|
Size Change: -8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
remove/block-settings-menu-callback-memoization
branch
from
52d4b80 to
01f02a0
Compare
tyxla
approved these changes
Mar 6, 2024
| }, | ||
| [ __experimentalSelectBlock ] | ||
| ); | ||
| async function updateSelectionAfterDuplicate( clientIdsPromise ) { |
There was a problem hiding this comment.
Only used inline; good to be un-memoized 👍
| if ( ! blockToFocus ) { | ||
| blockToFocus = getBlockOrder()[ 0 ]; | ||
| } | ||
| function updateSelectionAfterRemove() { |
There was a problem hiding this comment.
Only used inline; good to be un-memoized 👍
| }, | ||
| [ currentClientId, openedBlockSettingsMenu, setOpenedBlockSettingsMenu ] | ||
| ); | ||
| function onToggle( localOpen ) { |
There was a problem hiding this comment.
While this is passed down, it's passed down to useControlledValue():
which is then used for the initial value of useState(), thus is utilized only on the first useState() call anyway.
Good to be un-memoized as well 👍
| [ __experimentalSelectBlock ] | ||
| ); | ||
| async function updateSelectionAfterDuplicate( clientIdsPromise ) { | ||
| if ( ! __experimentalSelectBlock ) { |
There was a problem hiding this comment.
Thanks for reducing the nesting level here 👍
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…dPress#59397) * Block Editor: Don't memoize callbacks in 'BlockSettingsDropdown' * Don't pass argument to 'updateSelectionAfterRemove' Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes unnecessary callback memoization in the
BlockSettingsDropdowncomponent.Why?
These callbacks aren't passed as effect dependencies or memoized component props. There's no need to ensure their stable reference.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast