-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds import statement to code usage example #59327
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
This documentation is auto-generated from JSDoc. Therefore, you need to update the following locations: gutenberg/packages/html-entities/src/index.js Lines 9 to 14 in 593fd64
Then run |
Makes sense about the auto-generation. Thanks @t-hamano for explaining how to commit here- I've pushed an update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm a little concerned that the GitHub action related to backporting PHP is failing, but this PR does not make any changes to PHP files, and this GitHub action is optional. Therefore, I will merge this PR 👍
What?
This is a minor documentation change to add the
import
statement to the code example. This seems to be a consistent pattern. Examples from other packages:Why?
Added for consistency and because import statements in the example code can be helpful for newer developers.