Fix canvas iframe button accessibility and silent tab stops #59317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
requested review from
kevin940726,
Mamaduka and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +455 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/canvas-iframe-button-accessibility
branch
from
1d8068b to
fab25e5
Compare
carolinan
approved these changes
Feb 27, 2024
SergeyBiryukov
approved these changes
Feb 27, 2024
anomiex
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Mar 15, 2024
After probably WordPress/gutenberg#59317 made the editor iframe be considered a button labeled "Edit", a test started failing complaining about there being two such buttons: ``` locator.click: Error: strict mode violation: locator('body.block-editor-page').getByRole('button', { name: 'Edit', exact: true }) resolved to 2 elements: 1) <button type="button" aria-label="Edit" class="component…>…</button> aka getByLabel('Navigation').getByLabel('Edit') 2) <iframe tabindex="0" role="button" aria-label="Edit" nam…></iframe> aka locator('iframe[name="editor-canvas"]') ``` This fixes it by narrowing the search to the "Navigation" section of the page.
7 tasks
anomiex
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Mar 15, 2024
After probably WordPress/gutenberg#59317 made the editor iframe be considered a button labeled "Edit", a test started failing complaining about there being two such buttons: ``` locator.click: Error: strict mode violation: locator('body.block-editor-page').getByRole('button', { name: 'Edit', exact: true }) resolved to 2 elements: 1) <button type="button" aria-label="Edit" class="component…>…</button> aka getByLabel('Navigation').getByLabel('Edit') 2) <iframe tabindex="0" role="button" aria-label="Edit" nam…></iframe> aka locator('iframe[name="editor-canvas"]') ``` This fixes it by narrowing the search to the "Navigation" section of the page.
billrobbins
pushed a commit
to Automattic/wp-calypso
that referenced
this pull request
Mar 20, 2024
After probably WordPress/gutenberg#59317 made the editor iframe be considered a button labeled "Edit", a test started failing complaining about there being two such buttons: ``` locator.click: Error: strict mode violation: locator('body.block-editor-page').getByRole('button', { name: 'Edit', exact: true }) resolved to 2 elements: 1) <button type="button" aria-label="Edit" class="component…>…</button> aka getByLabel('Navigation').getByLabel('Edit') 2) <iframe tabindex="0" role="button" aria-label="Edit" nam…></iframe> aka locator('iframe[name="editor-canvas"]') ``` This fixes it by narrowing the search to the "Navigation" section of the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47780
Fixes #51540
What?
In the Site editor, in view mode, the preview iframe behaves like a button to switch the editor to edit mode. That's mainly for keyboard interaction and screen reader users. However:
Why?
How?
role=button:viewModePropstoviewModeIframePropsas those ar props for the iframe.Testing Instructions
Terminology reminder; the 'view mode' is the initial state fo the Site editor, the one that shows the navigation panel and the site preview.
edit-site-visual-editor__editor-canvas:Testing Instructions for Keyboard
Screenshots or screencast