Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace isSmall prop WordPress/Gutenberg#53560 #59302

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Replace isSmall prop WordPress/Gutenberg#53560 #59302

merged 3 commits into from
Mar 9, 2024

Conversation

inc2734
Copy link
Contributor

@inc2734 inc2734 commented Feb 23, 2024

What?

Replaced the isSmall property with size="small" for DropdownMenu components.

Why?

#53560

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: inc2734 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: skorasaurus <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: jaclync <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 23, 2024
@t-hamano t-hamano added the [Package] Components /packages/components label Mar 7, 2024
@t-hamano t-hamano linked an issue Mar 7, 2024 that may be closed by this pull request
Button: Replace deprecated isSmall property with size="small" property #53560
Closed
@t-hamano t-hamano mentioned this pull request Mar 7, 2024
Closed
@t-hamano
Copy link
Contributor

t-hamano commented Mar 7, 2024

Sorry for the late reply. It appears that some of the code that this PR is trying to change has already been updated in trunk, causing a conflict. Can you resolve this conflict?

Once this PR is merged, all isSmall prop replacements should be complete.

Thank you!

@inc2734 inc2734 closed this Mar 7, 2024
@inc2734 inc2734 force-pushed the migrate-dropdown-menu-issmall-prop branch from 434d062 to 2071a26 Compare March 7, 2024 13:15
@inc2734
Copy link
Contributor Author

inc2734 commented Mar 7, 2024

Sorry! I think I did something wrong with the operation!

@t-hamano
Copy link
Contributor

t-hamano commented Mar 7, 2024

If you have time to continue working on this PR, please feel free to reopen. I will be happy to review it 👍

@inc2734 inc2734 reopened this Mar 7, 2024
@t-hamano t-hamano self-requested a review March 9, 2024 11:10
t-hamano
t-hamano approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@t-hamano t-hamano merged commit 4d9a27e into WordPress:trunk Mar 9, 2024
57 of 58 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 18.0
Development

Successfully merging this pull request may close these issues.

Button: Replace deprecated isSmall property with size="small" property
3 participants
@inc2734 @t-hamano @Mamaduka