-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Palette: Prevent mode switching if only one editor mode is available #59299
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +34 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #57604
What?
This PR fixes an issue where it was possible to switch modes via the command palette even though either visual mode or code editor mode was disabled.
Why?
The options menu refers to the editor settings and determines whether the button to toggle editor mode is enabled. However, the editor settings are not referenced in the command palette.
How?
Refer to the editor settings and add a command to toggle the code editor only if both modes are enabled.
Testing Instructions
In advance, write the following code into
gutenberg.php
to disable code editor mode: