Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @global to PHP doc comments #59287

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

shail-mehta
Copy link
Member

Added Global documentation according to PHP Documentation Standards.

Fixes: #59286

Copy link

github-actions bot commented Feb 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shail-mehta! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 22, 2024
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Feb 22, 2024
@fabiankaegy fabiankaegy added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Developer Documentation Documentation for developers labels Feb 23, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shail-mehta 👋

Thanks for adding this.

Currently the checks are failing here because of additional whitespaces: https://github.com/WordPress/gutenberg/actions/runs/8008119794/job/21873818816?pr=59287#step:9:10

Once that is fixed this can get merged

@fabiankaegy fabiankaegy changed the title Added Global Documentation Add @global to PHP doc comments Feb 23, 2024
@shail-mehta
Copy link
Member Author

Hey @shail-mehta 👋

Thanks for adding this.

Currently the checks are failing here because of additional whitespaces: https://github.com/WordPress/gutenberg/actions/runs/8008119794/job/21873818816?pr=59287#step:9:10

Once that is fixed this can get merged

Thanks for the feedback @fabiankaegy

I have Resolved Phpcs issues.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@fabiankaegy fabiankaegy merged commit e1b4e26 into WordPress:trunk Feb 23, 2024
56 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 23, 2024
@shail-mehta shail-mehta deleted the add-global-documentation branch April 7, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants