Block Mover: Unify visual separator when show button label is on #59158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +8 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
This PR also includes a fix for regression (#57640) introduced in WP6.5. So I would like to add it to the project board and give it a backport label. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
Flaky tests detected in 07cbee8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7953623200
|
aaronrobertshaw
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Thanks for cleaning this up @t-hamano 👍
I can replicate the original issue with the separator and confirm this PR fixes the problem.
| Before | After |
|---|---|
Screen.Recording.2024-02-21.at.11.17.43.am.mp4 |
Screen.Recording.2024-02-21.at.11.23.03.am.mp4 |
LGTM 🚢
|
@aaronrobertshaw Thanks for the review! |
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
) Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: afercia <[email protected]>
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: c515c6c |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
) Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: afercia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58999
Follow-up #57640
What?
This PR unifies the visual separator between mover buttons when "show button label" is on.
Why?
The main problem is that when the buttons are placed horizontally, the horizontal border overlaps the text.
There are other consistency issues to resolve as reported in #58999.
How?
I adjusted the CSS for the separator based on the rules below.
Testing Instructions
Screenshots or screencast
57121f3bbfab1f68ea66dec0d8a44510.mp4