JSON schema: Update schema for background support

[t-hamano]

Follow up #53934 and #57005

What?

This PR adds and updates background support definitions in theme.json and block.json.

Why?

To enhance the developer experience.

How?

I've updated the description to reflect the actual implementation, but one point that confused me is that backgroundSize actually covers three things: background-size, background-position, and background-repeat. That's why I mentioned it in the description.

Testing Instructions

• Create a JSON file locally using the test data below.
• Make sure the code editor properly indicates suggestions, default values, and description.

theme.json

{
	"$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/schema/add-background-image/schemas/json/theme.json",
	"version": 2,
	"settings": {
	}
}

theme.json.mp4

block.json

{
	"$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/schema/add-background-image/schemas/json/block.json",
	"version": "2",
	"name": "test/test",
	"title": "test",
	"supports": {
	}
}

block.json.mp4

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: andrewserong <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[andrewserong]

Thanks for fixing this up @t-hamano, and for the great testing instructions, that made it easy to double-check that it's working correctly!

but one point that confused me is that backgroundSize actually covers three things: background-size, background-position, and background-repeat. That's why I mentioned it in the description.

Yes, it isn't obvious at first, but during work on the features it became apparent that repeat and position controls cannot reasonably exist separately to backgroundSize, so it would be better for the features to be consolidated in terms of settings, into the catch-all of backgroundSize.

If we wanted to make this grouping clearer, we could perhaps adjust the wording in the schema to something like Allow blocks to define values related to the size of a background image, including size, position, and repeat controls.

That said, I like the wording you've gone with, so this LGTM, too! ✨

[t-hamano]

@andrewserong Thanks for the review!

If we wanted to make this grouping clearer, we could perhaps adjust the wording in the schema to something like Allow blocks to define values related to the size of a background image, including size, position, and repeat controls.

I also feel that this is more clear 👍

theme.json:

block.json:

[andrewserong]

Nice tweaks there, that reads well to me!

[github-actions]

Flaky tests detected in f53f565.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7953100288
📝 Reported issues:

• [Flaky Test] default to the only existing classic menu if there are no block menus #48033 in /test/e2e/specs/editor/blocks/navigation.spec.js

[t-hamano]

Oh sorry, I forgot to update the prop...

[andrewserong]

No worries! 😄

[carolinan]

Isn't this feature enabled by default? Should it be true, not false?
Update: nevermind, of course I forgot to delete appearancetools when I was testing something :)